[ 
https://issues.apache.org/jira/browse/BIGTOP-715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13727292#comment-13727292
 ] 

Peter Linnell commented on BIGTOP-715:
--------------------------------------

+1 LGTM

Nits:

we should use /bin/bash not bin/sh this has been in other discussions
Line 1040 do we need :

%attr(0755,root,root)

so that:
+%{bin}/spark-shell
+%{bin}/spark-executor  have the right permissions? Better to set them 
explicitly IMO. 

Not clear about the Scala version comment. Can we depend on a system installed 
version ?  If so, we could list this as Buildrequires or Requires in the spec 
file.





                
> Add Spark packaging
> -------------------
>
>                 Key: BIGTOP-715
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-715
>             Project: Bigtop
>          Issue Type: Task
>          Components: Debian, RPM
>    Affects Versions: 0.3.1, 0.5.0
>            Reporter: MTG dev
>            Assignee: Konstantin Boudnik
>              Labels: hackathon-7-2013
>         Attachments: BIGTOP-715.master-0.8.patch, 
> BIGTOP-715.master-0.8.patch, BIGTOP-715.master-0.8.patch, 
> BIGTOP-715.master-0.8.patch, BIGTOP-715.master-0.8.patch, BIGTOP-715.patch, 
> BIGTOP-715.spark7.patch, BIGTOP-715.spark7.patch, BIGTOP-715.spark7.patch
>
>
> It would be great to add Spark native packages to the BigTop.
> Spark project is in-memory fast data analytic project from Berkeley 
> (www.spark-project.org) 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to