[ 
https://issues.apache.org/jira/browse/BIGTOP-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13799284#comment-13799284
 ] 

Martin Bukatovic commented on BIGTOP-1032:
------------------------------------------

Thank you for the feedback!

I created the fork as suggested, so you can find the changes in this branch:
https://github.com/mbukatov/bigtop/tree/BIGTOP-1032

Regarding 3) - you are right here, I just reused what the previous version 
used, but will definitely address that. 

> Refactor hdfs/TestCLI and hdfs/TestAppend to be generic filesystem tests 
> -------------------------------------------------------------------------
>
>                 Key: BIGTOP-1032
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1032
>             Project: Bigtop
>          Issue Type: Improvement
>            Reporter: jay vyas
>         Attachments: FSCmdExecutor.java, TestCLI.java
>
>
> The TestCLI and TestAppend classes both have hard references to an HDFS user 
> shell, although most of their functionality is actually geared towards 
> testing the abstract FileSystem interface. 
> Removing a couple of lines from TestCLI:
>     String[] createTestcliDirCmds = {"hadoop fs -mkdir -p " + 
> TEST_DIR_ABSOLUTE,
>       "hadoop fs -chmod 777 " + TEST_DIR_ABSOLUTE};
>     shHDFS.exec(createTestcliDirCmds);
> And a this line from TestAppend:
>     shHDFS.exec("hadoop fsck 
> /user/$USERNAME/$testAppendInput/test2.file$date");
> This will essentially allow bigtop suites to be used to validate file system 
> functionality in clusters with heterogenous 
> https://wiki.apache.org/hadoop/HCFS/ implementations.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to