[
https://issues.apache.org/jira/browse/BIGTOP-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803175#comment-13803175
]
Mark Grover commented on BIGTOP-1125:
-------------------------------------
Thanks Sean.
I am happy with the typo correction (good find!). However, I am a little
concerned about changing the exit code of the script at the bottom. Even though
I believe that's the right thing to do, I think it may warrant a little more
testing.
While I haven't tried this myself but in case stop() returns an error, the last
line in that method is echo "ERROR: "
([reference|https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/hbase/regionserver-init.d.tpl#L335])
This would return 0 from the function which means the script returns success
even though it was an error
([reference|https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/hbase/regionserver-init.d.tpl#L400]).
Am I understanding it correct? Please let me know what you think!
> Return value does not reflect status checks
> -------------------------------------------
>
> Key: BIGTOP-1125
> URL: https://issues.apache.org/jira/browse/BIGTOP-1125
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Fix For: 0.8.0
>
> Attachments:
> 0001-BIGTOP-1125.-Return-value-does-not-reflect-status-ch.patch
>
>
> The init script for HBase RegionServers that supports multiple processes is
> always returning 0. It should return 0 on success of non-zero on failure. In
> the case of running multiple processes, failure is defined as a failure
> There are already different constants defined in the file (e.g. different
> values for failures in all process, failures in some processes, failures in
> no processes... etc.), we just need to return them properly.
> Although this affects the 0.7.0 RC, I don't consider it a big enough deal to
> warrant -1'ing the RC, which I'm still testing.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
