[
https://issues.apache.org/jira/browse/BIGTOP-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13824645#comment-13824645
]
Bruno Mahé commented on BIGTOP-1128:
------------------------------------
+1
Great!
I don't see this in the original file and am no expert in groovy, so I won't
complain too loudly but what about:
* Would be great to use final for constants
* Not mixing tabs and spaces. Popular IDEs can automatically format code to
some defined guidelines. Maybe Apache Bigtop should define one?
* {noformat}+ assertEquals("Unable to create work dir in HCFS", 0,
sh.getRet());{noformat} -> I think you meant HDFS
* Code is not indented. Some parts do not match. Would be great to have a
uniform indentation.
* Defining all constants at a top of a class (ie. ITERATIONS)
> FIX and modularize mahout sample data sets
> ------------------------------------------
>
> Key: BIGTOP-1128
> URL: https://issues.apache.org/jira/browse/BIGTOP-1128
> Project: Bigtop
> Issue Type: Bug
> Reporter: jay vyas
> Assignee: jay vyas
> Attachments: BIGTOP-1128.1.patch
>
>
> The mahout smokes have alot of dependencies
> Concretely, we need to fix the movie lens sample data which has moved....
> from http://www.grouplens.org/system/files/ml-1m.zip
> to http://files.grouplens.org/papers/ml-1m.zip
> Otherwise mahout smokes break for obvious reasons.
> More generally, consolidating and verifying these download URLs in a separate
> function might make for simpler debugging of the tests, otherwise, you get
> html documents stored as .zip files, which causes a very hard to interpret
> error in the tests, i.e. you get an exception about how the zip file isnt
> formatted correctly.
> Other Thoughts on how to simplify and isolate moving parts of mahout tests?
> We can bundle them into a patch. Would be a shame if the only thing this
> JIRA resulted in was a fix to a single URL :)....
--
This message was sent by Atlassian JIRA
(v6.1#6144)
