[
https://issues.apache.org/jira/browse/BIGTOP-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845169#comment-13845169
]
Bruno Mahé commented on BIGTOP-1157:
------------------------------------
Indeed. It's just eclipse almost default formatting (just changed the default
settings to 120char long lines).
The main differences in the main pom.xml are roughly:
New properties:
{noformat}
<maven.build.timestamp.format>
yyyy-MM-dd'T'HH:mm
</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
{noformat}
Inside the <executions> tag of docbkx-maven-plugin:
{noformat}
<execution>
<id>pdf</id>
<goals>
<goal>generate-pdf</goal>
</goals>
<phase>pre-site</phase>
<configuration>
<imgSrcPath>${basedir}/src/site/resources/images/</imgSrcPath>
</configuration>
</execution>
{noformat}
Some configuraation properties have also been added/tweaked.
Regarding the spaces, I am more of a tabs kind of guy but don't really mind as
long as we are consistent.
So I am going to do the following:
* Since I got a +1 and this space issue is considere as a nit by my reviewers,
I will commit this patch as is
* Now that we have the frame of the user guide, I will send another patch
shortly with some first content. This patch will re-format the pom.xml and the
base xml files for the docbook according to whatever is specified in this
ticket and therefore fix this space issue.
Regarding the specifications for the XML formatting, why would you like to see ?
Here is a first proposition from the other pom.xml in the bigtop-tests
subdirectory:
* 120 character long lines
* 2 spaces per level of indentation
> Add a new Apache Bigtop user guide
> ----------------------------------
>
> Key: BIGTOP-1157
> URL: https://issues.apache.org/jira/browse/BIGTOP-1157
> Project: Bigtop
> Issue Type: New Feature
> Reporter: Bruno Mahé
> Assignee: Bruno Mahé
> Attachments:
> 0001-BIGTOP-1157.-Add-a-new-Apache-Bigtop-user-guide.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
