[ 
https://issues.apache.org/jira/browse/BIGTOP-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887511#comment-13887511
 ] 

Konstantin Boudnik commented on BIGTOP-1192:
--------------------------------------------

Looks better! 

- I guess this
{noformat}
    switch (OS.linux_flavor) {
      case ~/(?is).*(ubuntu|debian).*/:
        CRON_SERVICE = "cron"
        break
      case ~/(?is).*(redhat|centos|rhel|fedora|enterpriseenterpriseserver).*/:
        CRON_SERVICE = "crond"
        break
      case ~/(?is).*(suse|sles|sled).*/:
        CRON_SERVICE = "cron"
      default:
        CRON_SERVICE = "cron"
    }
{noformat}
can be simplified to something like
{noformat}
    switch (OS.linux_flavor) {
      case ~/(?is).*(redhat|centos|rhel|fedora|enterpriseenterpriseserver).*/:
        CRON_SERVICE = "crond"
        break
      default:
        CRON_SERVICE = "cron"
    }
{noformat}
- I am seeing {{testServiceKilled}} is failing on my machine with 
{{java.lang.AssertionError: cron hasn't been killed as expected:. Expression: 
this.isCronRunning() }}
whenever is running along with the other tests. Does it require any particular 
order of execution between this one and {{testServiceRestart}} ? If so, iTest 
provides an extension for JUnit to setup tests execution order.

I think we are almost there!

> Add utilities to facilitate cluster failure testing into bigtop-test-framework
> ------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1192
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1192
>             Project: Bigtop
>          Issue Type: New Feature
>          Components: Tests
>    Affects Versions: 0.7.0
>            Reporter: Mikhail Antonov
>            Assignee: Mikhail Antonov
>              Labels: itest, smokes
>             Fix For: 0.8.0
>
>         Attachments: BIGTOP-1192.1.patch, BIGTOP-1192.2.patch, 
> BIGTOP-1192.3.patch, BIGTOP-1192.4.patch
>
>
> The goal is to provide Bigtop module maintainers with a set of set of util 
> classes to help develop smoke tests able to simulate certain failures during 
> smoke tests execution on a cluster.
> Summary of what is provided in current patch. 
> Following failure types are supported now:
>  - Service stopped and restarted (on given set of nodes)
>  - Service killed with 'kill -9' and started back up (on given set of nodes)
>  - Node inbound/outbound connections are shut down and brought back up (via 
> iptables).
>  
> System requirements to run smoke tests with failures.
>  *  password-less (PKI-based) root ssh to all nodes in cluster being tested 
> is assumed.
>  *  for local tests, like ClusterFailuresTest, one should have password-less 
> root ssh to localhost.
>  *  env variable BIGTOP_SMOKES_CLUSTER_IDENTITY_FILE should point to 
> according private key file.
> Further thoughts (not included in this patch)
>   Cluster provisioning
>    - Bigtop test framework (failures part of it) doesn't need to know about 
> cluster topology, as it simply executes set of SSH commands on remote hosts 
> (whose addresses are provided by specific
>    module smoke test developer). But the actual tests do need to know about 
> cluster topology to run sophisticated failure scenarios.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to