[
https://issues.apache.org/jira/browse/BIGTOP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13906549#comment-13906549
]
jay vyas edited comment on BIGTOP-1213 at 2/20/14 3:24 AM:
-----------------------------------------------------------
Thanks Dasha... how did you make this patch? (someone else correct me if im
wrong... ) but I tried to apply but i think you might have formatted the patch
differently... Git can't apply it for me. Here is my workflow that mark
grover initially gave me. Can you try it out and resubmit the patch? Thanks!
1.put the changes all in 1 commit w/ a umbrella commit message i.e.
"BIGTOP-1213: TestHadoopExamples fixes" .
2. run
{noformat}
git format-patch HEAD^..HEAD --stdout > BIGTOP-1213.patch
{noformat}
3. Upload the BIGTOP-1213.patch file to this JIRA
was (Author: jayunit100):
Thanks Dasha... how did you make this patch? I tried to apply but i think you
might have formatted the patch differently... Git can't apply it for me.
Here is my workflow that mark grover initially gave me. Can you try it out and
resubmit the patch? Thanks!
1.put the changes all in 1 commit w/ a umbrella commit message i.e.
"BIGTOP-1213: TestHadoopExamples fixes" .
2. run
{noformat}
git format-patch HEAD^..HEAD --stdout > BIGTOP-1213.patch
{noformat}
3. Upload the BIGTOP-1213.patch file to this JIRA
> BigTop map defining TestHadoopExamples smokes ~ orderering is
> nondeterministic of tests. Should be orderd.
> -----------------------------------------------------------------------------------------------------------
>
> Key: BIGTOP-1213
> URL: https://issues.apache.org/jira/browse/BIGTOP-1213
> Project: Bigtop
> Issue Type: Bug
> Reporter: jay vyas
> Assignee: Dasha Boudnik
> Attachments: BIGTOP-1213.patch
>
>
> According to the JDK contract for a Map, the order of iteration is not
> gauranteed.
> But in TestHadoopExamples.groovy, we define a map and iterate through it.
> The tests should run in the defined order,
> 1) both for determinism, as well
> 2) so that TeraGen always runs before TeraSort
> {noformat}
> static Map examples =
> [
> pi :'5 10',
> wordcount :"$EXAMPLES/text $EXAMPLES_OUT/wordcount",
> teragen :"${terasort_rows} teragen${terasortid}",
> terasort :"teragen${terasortid} terasort${terasortid}",
> teravalidate :"terasort${terasortid} tervalidate${terasortid}",
> ...
> ];
> {noformat}
> examples.each { k, v -> res[k] = [k.toString(), v.toString()] as
> Object[]; }
> {noformat}
> While implementing this JIRA, we can also add in some other minor
> improvements :
> - Parameterization of calculate pi so that it can run fast on VMS
> - Remove "sleep" , as its not in newer versions of YARN ( i think, need to
> confirm)
> TL;DR, Im proposing a fix to add concreted deterministic JDK-independant
> ordering to the Map so tests always run in same order + a few minor upgrades
> to this class while were at it.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
