[
https://issues.apache.org/jira/browse/BIGTOP-1209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13907797#comment-13907797
]
Konstantin Boudnik commented on BIGTOP-1209:
--------------------------------------------
- License boiler plate should have the empty line, but they shouldn't have
{{<p>}} in it. So, it should look like
{noformat}
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
{noformat}
as can be seen in [here|http://www.apache.org/licenses/LICENSE-2.0]
- the class doc says {{/** SLive Stress test}} which isn't fully correct, as
you're contributing longevity test that can be used for stress and other
purposes. Please change this.
- {{ public void cleanup() { }} can be made private
- asserts need to have meaningful messages
The rest looks good.
> Add SLive test into longevity suite
> -----------------------------------
>
> Key: BIGTOP-1209
> URL: https://issues.apache.org/jira/browse/BIGTOP-1209
> Project: Bigtop
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: Konstantin Boudnik
> Assignee: Virginia Wang
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1209.patch, BIGTOP-1209.patch
>
>
> More sophistication with SLive, where we can start testing variational load
> of the cluster, etc.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
