[
https://issues.apache.org/jira/browse/BIGTOP-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated BIGTOP-1215:
----------------------------------
Attachment: 0001-BIGTOP-1215.-Refactor-Tomcat-deployment.patch
Thanks for the review, Mark! I've made a couple of very insignificant tweaks: I
changed the comments to refer to tomcat-deployment.sh as a "script" instead of
a "directory", and I added tomcat-deployment.sh to the lists of source files in
the relevant spec files (I don't know why it sometimes succeeds if you miss
that).
I trust that doesn't alter your review of the patch, but for the sake of being
proper, might I get a +1 on those changes before committing? I've updated the
ReviewBoard as well.
> Refactor Tomcat deployment
> --------------------------
>
> Key: BIGTOP-1215
> URL: https://issues.apache.org/jira/browse/BIGTOP-1215
> Project: Bigtop
> Issue Type: Bug
> Reporter: Sean Mackrory
> Assignee: Sean Mackrory
> Attachments: 0001-BIGTOP-1215.-Refactor-Tomcat-deployment.patch,
> 0001-BIGTOP-1215.-Refactor-Tomcat-deployment.patch
>
>
> Since my original changes to have Tomcat configuration stored in /etc, with
> only binaries under /usr/lib, I've had a few thoughts on how it should've
> been done better that I'd like to get in before 0.8.0, which would be the
> first release my changes are included in.
> * The code for doing the deployment should be a separate script, rather than
> a function defined separately in each entry point. This will reduce code
> duplication and prevent inconsistency, and also make it clearer for users
> following along.
> * The code in /etc only includes the /conf/ folder. There are some other
> config files that may need to be edited by users for things like HTTPS
> support. These should be stored in /etc as well and deployed at the same time.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
