[
https://issues.apache.org/jira/browse/BIGTOP-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910634#comment-13910634
]
Mark Grover commented on BIGTOP-1218:
-------------------------------------
Thanks Cos, appreciate you taking the time to review this!
1. {quote}
split jdk manifest from jdk6 and jdk7 in two: not everyone wants to have jdk7
installed by default.
{quote}
I am 50/50 on this. The benefit of separating the two is that folks who don't
want JDK7 wouldn't get it. The ill-effect is that our build slaves will start
to look different. Some slaves would have JDK7 on it, some wouldn't. I am not a
sysadmin but if consistency amongst slaves (atleast those who have the same OS)
is desirable (and I would think it is), it would be good to have JDK7 installed
on all. I would re-iterate here that installing JDK7 the way suggested in the
patch shouldn't modify any of the existing workflows. Everything runs JDK6 and
continues to do so, the goal is for JDK7 to sit there on the side and be
available for anyone to use if they so desire.
Cos, if you have any more thoughts on this, I'd love to hear them and if anyone
else would like to share thoughts on this specifically, that'd be much
appreciated!
2. {quote}
Let's use a permanently named link pointing to JAVA7_HOME instead of +export
JAVA7_HOME=/usr/lib/jdk1.7.0_45. With the current approach someone will have to
change this every single time when the JDK version is getting updated. Do
something like /usr/lib/java7-latest instead
And, FWIW, I had a tough time getting Oracle's JDK6 rpm to be installed
side-by-side
{quote}
Will do.
3. {quote}
There's an easy way of getting binary distribution of JDK from Oracle website
which doesn't require any complications with repos, etc. Check this post
{quote}
I was following the same method that we use for JDK6. However, this seems like
a reasonable suggestion, I will create a separate follow-up JIRA to consider
your suggestion for both JDK6 and JDK7.
> Add JDK7 to Bigtop toolchain
> ----------------------------
>
> Key: BIGTOP-1218
> URL: https://issues.apache.org/jira/browse/BIGTOP-1218
> Project: Bigtop
> Issue Type: Bug
> Components: Build
> Affects Versions: 0.8.0
> Reporter: Mark Grover
> Assignee: Mark Grover
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1218.1.patch
>
>
> Brock Noland filed a request for adding JDK7 to Bigtop toolchain so they can
> use it in their Hive pre-commit/integration test jobs. This JIRA will track
> that effort.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
