[
https://issues.apache.org/jira/browse/BIGTOP-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920175#comment-13920175
]
Konstantin Boudnik edited comment on BIGTOP-1240 at 3/4/14 11:08 PM:
---------------------------------------------------------------------
Actually, we are following Hadoop coding guidelines - I am pretty sure it has
been stated elsewhere.
There's nothing wrong with groovy formatting - they are the same as Java's. You
just need to use right tools for it. And Eclipse isn't a right tool.... for
anything ;)
Reviewboard can be used as a second-line tool: patches _have_ to be attached to
JIRA and reviews need to be posted as JIRA comments. If this requires an extra
integration with reviewboard - some one needs to address it.
was (Author: cos):
Actually, we are following Hadoop coding guidelines - I am pretty sure it has
been stated elsewhere.
There's nothing wrong with groovy formatting - they are the same as Java's. You
just need to use right tools for it. And Eclipse isn't a right tool.... for
anything ;)
> Formatting Guidelines
> ---------------------
>
> Key: BIGTOP-1240
> URL: https://issues.apache.org/jira/browse/BIGTOP-1240
> Project: Bigtop
> Issue Type: Task
> Components: General
> Reporter: jay vyas
>
> We need to expand
> https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute with
> - formatting guidelines for groovy . groovy seems tricky to format, not sure
> what guidelines to follow.
> - Also bigtop has many other file types (bash, puppet, etc...) so probably
> good to outline expectations for those to, or at least link to references.
> - patch submission guidelines : if we want to use reviewboard or other review
> tools how we will use them, and in what cases.
> This will make minor nits easier : just reference the code formatting
> guidelines.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
