[
https://issues.apache.org/jira/browse/BIGTOP-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13921359#comment-13921359
]
Konstantin Boudnik commented on BIGTOP-1240:
--------------------------------------------
Jay, it makes sense - thank you! One comment:
bq. set the "strip trailing spaces" option on save for all files
It should be set to "Save for modified files" - otherwise it will produce a
storm of unwarranted white-space changes in every patch.
bq. run "git am ../bigtop-jayunit100/BIGTOP-1221.4.intellij.patch
I won't encourage these custom naming schema for the patches, but it might be
just me ;)?
Can you add this to the wiki?
> Formatting Guidelines
> ---------------------
>
> Key: BIGTOP-1240
> URL: https://issues.apache.org/jira/browse/BIGTOP-1240
> Project: Bigtop
> Issue Type: Task
> Components: General
> Reporter: jay vyas
>
> We need to expand
> https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute with
> - formatting guidelines for groovy . groovy seems tricky to format, not sure
> what guidelines to follow.
> - Also bigtop has many other file types (bash, puppet, etc...) so probably
> good to outline expectations for those to, or at least link to references.
> - patch submission guidelines : if we want to use reviewboard or other review
> tools how we will use them, and in what cases.
> This will make minor nits easier : just reference the code formatting
> guidelines.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
