[
https://issues.apache.org/jira/browse/BIGTOP-1221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jay vyas updated BIGTOP-1221:
-----------------------------
Attachment: BIGTOP-1221.5.patch
hi mark, ... okay your comments definetly make sense, much easier to see what
you were talking about now since the minor stuff is fixed.
- i think the test0Echo and "test contents" are obsolete from an old patch.
- Ive now update the testCp to actually test contents using a diff. thats a
good idea.
- Added an assertion that the first mkdirs passed, again goot catch . your
right : it very well could fail if fuse mount is broken at the core.
- another good point that contains "hcfs" was fragile. Better to do
containes(testdir), also fixed that.
- regarding cat. I think we are in agreement on that now as per above comment.
- Regarding closting the file. Evidently magical groovy does it for you :)
http://www.coderanch.com/t/541995/Groovy/close-file
- I fixed the assert messages so that they all use Failure/Error semantics..
A bit hasty , prob error messages could be even better. but i think it will
satisfy the patch for now. Im planning on iterating on this patch very soon,
because FUSE mount semantics are quite complex, especially with the HA Jira
just filed, so we can keep improving it.
Now, after adding your cp verification, i found another inconsistency in HDFS,
but was able to workaround it by adding better FUSE mount options.
Im attaching the patch and will verify in the morning that its ready for
review.
> Expand and updated FUSE tests
> -----------------------------
>
> Key: BIGTOP-1221
> URL: https://issues.apache.org/jira/browse/BIGTOP-1221
> Project: Bigtop
> Issue Type: Bug
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: jay vyas
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1221-tested-refined-3.patch,
> BIGTOP-1221.4.intellij.patch, BIGTOP-1221.5.patch, BIGTOP-1221.patch
>
>
> The BigTop TestFuseDFS need
> - tests for consistency after individual writes : consistency in FUSE mounts
> is important since there are often associated multitenant workloads. Writes
> should result in immediate recognition of a file.
> - Should use HCFS semantics (That way we can confidently use and maintain
> this for alternative file system implementations).
> - should use logging instead of System.out. That way all the logs can be
> picked up from the same place in case we change the logging framework.
> Logging in trace mode, in any case, will allow us to see everything that the
> ITest shell does, and so might as well use it for other logs.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
