[
https://issues.apache.org/jira/browse/BIGTOP-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923212#comment-13923212
]
jay vyas commented on BIGTOP-952:
---------------------------------
Okay cos/bruno. I've responded to everything and here's what ive got so far:
https://gist.github.com/jayunit100/9401503
Its untested, so dont bother analyzing functional logic too much just yet, as I
will confirm it in VMs myself when i submit official patch.
Any initial thoughts? Im about to put a patch and officially test it later
tonite.
***************************
Responses/fixes inline:
- bruno: I split up stuff into methods etc, probably a good idea, it was
getting complex.
- in the process i also had to make methods return things, I personally hate
methods that work on global variables. overall result is more cleanable and
modular code so i guess it was worth it, even thought the script was a little
more hacker friendly.
-moved it to bigtop-utils as per cos's suggestion.
- added ASL boiler plate
- added groovy shebang
- I havent really used printlns for logs : but in a script, we want to
err.println and out.println. I think the usage is pretty uniform here unless a
specific one you want to point out that should be LOG?
- re: classpath, that'll be resolved in BIGTOP-1235
- fixed 80 line formatting
- System.exit clarified. good point. dont really know what i was thinking :).
- removed commented lines
-stationary paths externalized (Actually, i think these should be pulled in
from env variables eventually, but for now I put em in vars so they can easily
just be edited.
- Switched to groovy down casts
***********************
> init-hdfs.sh is dog slow. Let's replace it with a single VM call and better
> layout management
> ---------------------------------------------------------------------------------------------
>
> Key: BIGTOP-952
> URL: https://issues.apache.org/jira/browse/BIGTOP-952
> Project: Bigtop
> Issue Type: Improvement
> Components: Deployment
> Affects Versions: 0.5.0
> Reporter: Konstantin Boudnik
> Assignee: jay vyas
> Priority: Blocker
> Fix For: 0.8.0
>
> Attachments: BIGTOP-952-tested-refined.patch,
> BIGTOP-952-tested.patch, provision2.groovy, untar.groovy
>
>
> As has been proposed in [this
> patch|https://issues.apache.org/jira/secure/attachment/12575644/untarHdfs.groovy]
> by [~rvs] there's a very efficient way of creating layout in HDFS using a
> tarfile and Groovy script with direct call into DFS APIs.
> Let's making it happen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
