[
https://issues.apache.org/jira/browse/BIGTOP-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13933666#comment-13933666
]
Konstantin Boudnik commented on BIGTOP-1246:
--------------------------------------------
new patch looks good. +1 I will commit it now.
I have also noticed a few issues in the test:
- the package name is wrong. Either the path to test needs to be fixed or the
package name changed. I prefer the latter.
- there are unused imports
- there's a statement like {{exists == true}} where {{exists}} is a boolean
variable. You don't need '=='' here.
Could you please address it in a separate JIRA?
> Fix the shell-object bug in HttpFs smoke tests
> ----------------------------------------------
>
> Key: BIGTOP-1246
> URL: https://issues.apache.org/jira/browse/BIGTOP-1246
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Adam Kawa
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1246.1.patch, BIGTOP-1246.2.patch
>
>
> [~jaoki] has identified a bug in HttpFs smoke tests, where a different shell
> object was used to verify the return code from the command, than the one that
> really executed this command:
> {code}
> 110 sh.exec("curl -i -X DELETE
> '$HTTPFS_PREFIX$testHttpFsFolder?user.name=$USERNAME&op=DELETE'");
> 111 assertTrue("curl command to delete a dir failed", shHDFS.getRet()
> == 0);
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
