[
https://issues.apache.org/jira/browse/BIGTOP-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943709#comment-13943709
]
jay vyas edited comment on BIGTOP-1257 at 3/21/14 11:16 PM:
------------------------------------------------------------
(cleanup horrible typos)
TL;DR : Are we in agreement that a superclass test suite can be used to drive
both longevity AND regular hadoop examples? (i.e. lets call it
"AbstractHadoopExamplesSuite"),
And then have:
- "TestHadoopExamples extends AbstractHadoopExamplesSuite" ?
- And later in a next iteration, have "TestLongevityHadoopExamples extends
AbstractHadoopExamplesSuite".
was (Author: jayunit100):
TL;DR : Are we in agreement that a superclass test suite can be used to drive
(i.e. something like AbstractHadoopExamplesSuite),
- and the customary logic can be in TestHadoopExamples extends
AbstractHadoopExamplesSuite?
- and then, as next iteration, we can use that make the
TestLongevityHadoopExamples run extends AbstractHadoopExamplesSuite?
> Make TestHadoopExamples modular enough to support longevity tests.
> ------------------------------------------------------------------
>
> Key: BIGTOP-1257
> URL: https://issues.apache.org/jira/browse/BIGTOP-1257
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
>
> TestHadoopExamples is really just a super of what we eventually will add in
> the Longevity suite. It will be good to create a super class, then, which
> wraps the hadoop examples jars, whic BOTH the smoke tests AND longevity tests
> can both use and customize to suite their needs.
> Advantages:
> - less code duplication
> - easier to add in new longevity tests
> - longevity tests focus on customizing , rather than defining the tests
> classes.
> We can go about this two ways:
> 1) Use the approach of TestHadoopExamples: define all examples in a k/v map,
> with parameters or
> 2) Write individual unit tests for each benchmark (i.e. TestDFSIO), as is
> done in Dasha's BIGTOP-1208 patch.
> Part of this JIRA i think is to audit the longevity suite for other
> duplications, to see where we can merge efforts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
