[
https://issues.apache.org/jira/browse/BIGTOP-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943856#comment-13943856
]
jay vyas commented on BIGTOP-1257:
----------------------------------
Sure thats a good start. But I guess TestHadoopExamples will still be a large
class that isnt quite as easy to customize. But its a good start . So shall
we define that as the task :
- Refactor TestHadoopExamples so that each run test call in the K:V mapping can
easily be overriden in a subclass.
- Also add parameters where necessary so that any Longevity tests can be
written in a class that extends TestHadoopExamples.
> Make TestHadoopExamples modular enough to support longevity tests.
> ------------------------------------------------------------------
>
> Key: BIGTOP-1257
> URL: https://issues.apache.org/jira/browse/BIGTOP-1257
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
>
> TestHadoopExamples is really just a super of what we eventually will add in
> the Longevity suite. It will be good to create a super class, then, which
> wraps the hadoop examples jars, whic BOTH the smoke tests AND longevity tests
> can both use and customize to suite their needs.
> Advantages:
> - less code duplication
> - easier to add in new longevity tests
> - longevity tests focus on customizing , rather than defining the tests
> classes.
> We can go about this two ways:
> 1) Use the approach of TestHadoopExamples: define all examples in a k/v map,
> with parameters or
> 2) Write individual unit tests for each benchmark (i.e. TestDFSIO), as is
> done in Dasha's BIGTOP-1208 patch.
> Part of this JIRA i think is to audit the longevity suite for other
> duplications, to see where we can merge efforts.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
