[
https://issues.apache.org/jira/browse/BIGTOP-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011605#comment-14011605
]
Konstantin Boudnik commented on BIGTOP-1321:
--------------------------------------------
Yup, that's what I meant but failed to express.
One more comment: you need to make indentation in the code blocks like this
{code}
+ Assert.assertEquals("Creation of testcli dir should succeed and return 0" +
+ " (but it failed with the following error message: " +
+ StringUtils.join(shHDFS.getErr().toArray(), "\\n") + ")",
+ 0, shHDFS.getRet());
{code}
to be 4 spaces as this is a continuation of a statement. The new patch looks
good otherwise!
> TestCLI: check assumptions before the test run
> ----------------------------------------------
>
> Key: BIGTOP-1321
> URL: https://issues.apache.org/jira/browse/BIGTOP-1321
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.8.0
> Reporter: Martin Bukatovic
> Assignee: Martin Bukatovic
> Priority: Minor
> Attachments: BIGTOP-1321.1.patch, BIGTOP-1321.2.patch
>
>
> The TestCLI test cases has some assumptions which are not checked in the test
> code. This is a proposal to add checks for each important assumption which
> would make some cases fail if not met. This would save us some debugging time
> when setting up new test environment and would make this test easier to reuse.
> So far, I have identified these:
> * the effective user must be hdfs (a root for HDFS)
> * the HDFS trash feature must be disabled (`fs.trash.interval` should be 0)
> * hdfs://tmp/testcli_TIMESTAMP directory has been really created
> I expect there are additional assumptions worth checking, any other ideas?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
