[
https://issues.apache.org/jira/browse/BIGTOP-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14021228#comment-14021228
]
Andrew Purtell commented on BIGTOP-1285:
----------------------------------------
Patch looks good.
Minor stuff.
Why are we forcing a particular snappy version?
{code}
+ -Dsnappy.version=1.0.4.1 \
{code}
Have you tried installing the bigtop Phoenix package and its dependencies,
launching processes, and confirming the sqlline shell works?
{code}
-# Fix up sqlline.sh for Bigtop install layout
-sed -i -e s#target## -e
s#\$current_dir/log4j.properties#$ETC_DIR/conf/log4j.properties#
$PREFIX/$BIN_DIR/sqlline.sh
{code}
Phoenix is now a TLP, please drop 'incubator' in project URL references:
{code}
+Source: http://phoenix.incubator.apache.org
{code}
Otherwise looks great!
> Bump version of Phoenix to 4.0
> ------------------------------
>
> Key: BIGTOP-1285
> URL: https://issues.apache.org/jira/browse/BIGTOP-1285
> Project: Bigtop
> Issue Type: Sub-task
> Components: General
> Reporter: Andrew Purtell
> Assignee: YoungWoo Kim
> Fix For: 0.8.0
>
> Attachments: BIGTOP-1285.1.patch, BIGTOP-1285.2.patch,
> BIGTOP-1285.patch
>
>
> After BIGTOP-1281, we should bump the shipped version of Apache Phoenix to
> the 4.x release line, currently 4.0.0.
> Phoenix 4.x is meant to run on HBase 0.98. Phoenix 3.x is meant to run on
> HBase 0.96. Phoenix 2.x is meant to run on HBase 0.94.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
