[
https://issues.apache.org/jira/browse/BIGTOP-1337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14032776#comment-14032776
]
Manikandan Narayanaswamy edited comment on BIGTOP-1337 at 6/16/14 6:53 PM:
---------------------------------------------------------------------------
Uploading patch after testing changes on CentOS and Ubuntu.
Testing done:
Installed spark-history-server on Ubuntu and CentOS.
- Saw that we now log failure if the service fails to start.
- Saw success message only if the service actually started.
The changes are identical in other init scripts so did not verify all of them.
was (Author: mnarayan):
Uploading patch after testing changes on CentOS and Ubuntu.
Testing done:
Installed llama on Ubuntu and CentOS.
- Saw that we now log failure if the service fails to start.
- Saw success message only if the service actually started.
The changes are identical in other init scripts so did not verify all of them.
> Logging success messages in service startup and shutdown only after
> verification.
> ---------------------------------------------------------------------------------
>
> Key: BIGTOP-1337
> URL: https://issues.apache.org/jira/browse/BIGTOP-1337
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Manikandan Narayanaswamy
> Labels: packaging
> Fix For: 0.8.0
>
>
> Right now, it appears like we log success messages right at the beginning of
> the method call irrespective of whether the service was successfully stopped
> / started. In a scenario where the user issues "service serviceName start"
> and immediately sees a success message but, the service in reality has failed
> to start leads to some amount of confusion.
> The proposed change will only log success messages if the operation was
> actually successful.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
