[
https://issues.apache.org/jira/browse/BIGTOP-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14034715#comment-14034715
]
jay vyas edited comment on BIGTOP-1316 at 6/18/14 1:52 AM:
-----------------------------------------------------------
+1 [[email protected]] are you going to go ahead with commiting this ?
sorry , i got so distracted with the tangential issues, I forgot to actually
test the patch :) Just compiled itest after applying your patch, everything
looks ok, save a few linux specific test failures error which happen when
building on a mac.
((( And thanks BTW, its awesome that Slider is pushing back to bigtop )))
was (Author: jayunit100):
+1 [[email protected]] are you going to go ahead with commiting this ?
sorry , i got so distracted with the tangential issues, I forgot to actually
test the patch :) Just compiled itest after applying your patch, everything
looks ok, save a few linux specific test failures error which happen when
building on a mac.
> enhance Shell for better checking of return code & output logging
> -----------------------------------------------------------------
>
> Key: BIGTOP-1316
> URL: https://issues.apache.org/jira/browse/BIGTOP-1316
> Project: Bigtop
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.8.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: BIGTOP-1316-001.patch
>
>
> for the slider tests, we extended Shell with
> [SliderShellhttps://svn.apache.org/viewvc/incubator/slider/trunk/slider-funtest/src/main/groovy/org/apache/slider/funtest/framework/SliderShell.groovy?view=markup],
> adding some more features. Some of those are biased towards executing our
> entry point, but there are some useful core features worth pulling up to the
> base class
> # {{toString()}} and {{dump()}} methods with diagnostics
> # return code sign correction and assertion checking
> # construction of bash environment and command lines
> The bash setup could be done with a class {{Bash extends Shell}} which is
> designed purely for bash execution
--
This message was sent by Atlassian JIRA
(v6.2#6252)
