----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21293/#review46491 -----------------------------------------------------------
I pulled down your patch and applied it against master to do some testing. I had to make a few fixes (noted here) to get it working, but it seems solid otherwise! bigtop-packages/src/common/accumulo/accumulo-master.svc <https://reviews.apache.org/r/21293/#comment81879> This is doing some unexpected output echo (note the password not being hidden): <snip> Instance name : accumulo-bigtop accumulo-bigtop Enter initial password for root (this may not be applicable for your security setup): password ******** Confirm initial password for root: password ******** </snip> I should get the text that appears on the newline to the right of the prompt. Changing this line to `sudo -u $SVC_USER ${EXEC_PATH} init` makes the command operate as expected. I don't quite understand why, but it appears that something with the su is messing things up with the shell output. bigtop-packages/src/common/accumulo/conf/accumulo-site.xml <https://reviews.apache.org/r/21293/#comment81880> Either the HADOOP_CLIENT_HOME or HADOOP_PREFIX/lib entries need to exclude slf4j. Currently, you get a warning about multiple slf4j bindings. It doesn't matter which you change, but to make it easy, I changed the second to: $HADOOP_PREFIX/lib/(?!slf4j)[^.].*.jar - Josh Elser On May 9, 2014, 11:31 p.m., Sean Mackrory wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21293/ > ----------------------------------------------------------- > > (Updated May 9, 2014, 11:31 p.m.) > > > Review request for bigtop. > > > Bugs: BIGTOP-1175 > https://issues.apache.org/jira/browse/BIGTOP-1175 > > > Repository: bigtop > > > Description > ------- > > See JIRA > > > Diffs > ----- > > bigtop-packages/src/common/accumulo/accumulo-gc.svc PRE-CREATION > bigtop-packages/src/common/accumulo/accumulo-master.svc PRE-CREATION > bigtop-packages/src/common/accumulo/accumulo-monitor.svc PRE-CREATION > bigtop-packages/src/common/accumulo/accumulo-tracer.svc PRE-CREATION > bigtop-packages/src/common/accumulo/accumulo-tserver.svc PRE-CREATION > bigtop-packages/src/common/accumulo/conf/accumulo-env.sh PRE-CREATION > bigtop-packages/src/common/accumulo/conf/accumulo-metrics.xml PRE-CREATION > bigtop-packages/src/common/accumulo/conf/accumulo-site.xml PRE-CREATION > bigtop-packages/src/common/accumulo/conf/generic_logger.xml PRE-CREATION > bigtop-packages/src/common/accumulo/conf/log4j.properties PRE-CREATION > bigtop-packages/src/common/accumulo/conf/monitor_logger.xml PRE-CREATION > bigtop-packages/src/common/accumulo/do-component-build PRE-CREATION > bigtop-packages/src/common/accumulo/install_accumulo.sh PRE-CREATION > bigtop-packages/src/common/hadoop/init-hcfs.json > d8825aa33839b88d09ee928e0be83c46e88a2992 > bigtop-packages/src/common/hadoop/init-hdfs.sh > 3a5fe361dd56308f465a52214835a42900a618cd > bigtop-packages/src/deb/accumulo/accumulo-doc.install PRE-CREATION > bigtop-packages/src/deb/accumulo/accumulo.install PRE-CREATION > bigtop-packages/src/deb/accumulo/accumulo.postinst PRE-CREATION > bigtop-packages/src/deb/accumulo/accumulo.preinst PRE-CREATION > bigtop-packages/src/deb/accumulo/accumulo.prerm PRE-CREATION > bigtop-packages/src/deb/accumulo/compat PRE-CREATION > bigtop-packages/src/deb/accumulo/control PRE-CREATION > bigtop-packages/src/deb/accumulo/copyright PRE-CREATION > bigtop-packages/src/deb/accumulo/install_init_scripts.sh PRE-CREATION > bigtop-packages/src/deb/accumulo/rules PRE-CREATION > bigtop-packages/src/deb/accumulo/service-postinst.tpl PRE-CREATION > bigtop-packages/src/deb/accumulo/service-postrm.tpl PRE-CREATION > bigtop-packages/src/deb/accumulo/source/format PRE-CREATION > bigtop-packages/src/rpm/accumulo/RPMS/.gitignore PRE-CREATION > bigtop-packages/src/rpm/accumulo/SOURCES/.gitignore PRE-CREATION > bigtop-packages/src/rpm/accumulo/SPECS/.gitignore PRE-CREATION > bigtop-packages/src/rpm/accumulo/SPECS/accumulo.spec PRE-CREATION > bigtop-packages/src/rpm/accumulo/SRPMS/.gitignore PRE-CREATION > bigtop-packages/src/templates/init.d.tmpl > 57923240c2402c66b758790fcd8522186827f836 > bigtop.mk 672562a5d60b1043c7495183c8a5c4bcc571c960 > > Diff: https://reviews.apache.org/r/21293/diff/ > > > Testing > ------- > > See JIRA > > > Thanks, > > Sean Mackrory > >
