[ 
https://issues.apache.org/jira/browse/BIGTOP-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048356#comment-14048356
 ] 

Xin Hao commented on BIGTOP-1127:
---------------------------------

Hi, Sean and Roman, thanks for the comment, review and commit!

> Make return value of HBase RegionServer init script more explicit
> -----------------------------------------------------------------
>
>                 Key: BIGTOP-1127
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1127
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: Init scripts
>    Affects Versions: 0.7.0
>            Reporter: Sean Mackrory
>            Priority: Minor
>         Attachments: BIGTOP-1127.patch
>
>
> In the case statement at the very bottom of /etc/init.d/hbase-regionserver, 
> we are picking up the return code implicitly. We should perhaps be explicitly 
> collecting the code returned by each of the functions (start, stop, etc.) in 
> a new variable and return that variable in the end instead of $?. This might 
> make the code less fragile when being changed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to