[
https://issues.apache.org/jira/browse/BIGTOP-1360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049845#comment-14049845
]
jay vyas commented on BIGTOP-1360:
----------------------------------
I agree !!!!
Of course it's optional :)....Think from perspective of others: I agree For us
it's not a huge deal...
But for others:
1) they can contribute readme updates to bigtop without having to even use an
ide
2) they can modify their patches without having to resubmit an attachment
3) trillions of developers have github accounts which they use regularly....
It will grow the community around bigtop .
4) people who use a girhub fork for their specific changes can seamlessly push
those changes back up
I think. It's a numbers game - guys. The easier to contribute, the higher
likliehood that others will get involved .
I really wish people would just magically submit patches to jira.... But I see
in the spark community so many people actively submitting patches, I can't help
but think it's partially due to the ease of review process for newcomers.
> Our First Pull Request !
> ------------------------
>
> Key: BIGTOP-1360
> URL: https://issues.apache.org/jira/browse/BIGTOP-1360
> Project: Bigtop
> Issue Type: Improvement
> Components: General
> Reporter: jay vyas
>
> The spark community has done a great job integrating github into their
> workflow. Integrating this will be tricky : We need to make sure the script
> works. So lets have this JIRA both *create the script to commit from github*
> + also *confirm that it works* by creating a pull request, and *using* the
> script to actually merge that pull request in .
> Heres how the spark process works. We've confirmed in email thread that some
> of us agreed it will be good to do this.... From sparks commiter guidelines
> wiki page
> (https://cwiki.apache.org/confluence/display/SPARK/Reviewing+and+Merging+Patches):
> {quote}
> Once a patch is in good shape to merge, you can use the build-in developer
> script (./dev/merge_spark_pr.py) to merge it.
> This will also allow you to back-port the patch into earlier branches if
> required. Make sure to close the associated JIRA after you merge as well as
> indicating the fix versions.
> {quote}
> 1) create and test a script similar to dev/merge_spark_pr.py on a mock patch.
> 2) upload that script here, as a patch, for review.
> 3) After review is completed - take the code which creates this patch, and
> create a pull request by forking apache/bigtop.git
> 4) Use the script in your *fork* to commit the patch with the script. The
> script should
> * commit the correct patch to apache git
> * update this JIRA with "resolved" status
> If EITHER step fails, but commit goes through - we will create a follow up
> JIRA to fix the issue.
> Does this sounds like a plan we can agree on ?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
