[
https://issues.apache.org/jira/browse/BIGTOP-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077341#comment-14077341
]
jay vyas edited comment on BIGTOP-1222 at 7/29/14 3:32 AM:
-----------------------------------------------------------
Hi cos. Thanks for looking at it. I just ran a code formatter and it only
found one tab, and replaced it with spaces. I think the spaces/tabs are all
fixed (i'll double check tomorrow morning - its late here and my eyeballs are a
little weary).
1) removed the extra flume.conf good catch. Thats generated by the framework
actually.
2) Cleaned up the blank lines in the multiline runtime exception.
3) I actually would like to *keep the explicit tests files* for now. Maybe we
can add the dynamic stuff later on? For now, all tests are implemented by
explitly specifying them.
I agree its inelegant - but its uniform. Over time, we can add looser regexes
/etc for the tests which are in directories that don't require filters.
4) Regarding pi and the DFS comment changes : Out of scope? Sort of... but
Part of this JIRA is to clean up the tests to make tests easy to run - and that
means having accurate commants / reasonable defaults.
5) I've added back in the uncommented code: It is still used when we run tests
from jars, and I think we should support that functionality for while folks
migrate over to the new framework.
so, above is a quick patch which fixes *some but not all* of the stuff you
mentioned. I'll take another look *in the morning and test it to make sure it
works* and also re-review your comments.
was (Author: jayunit100):
Hi cos. Thanks for looking at it. I just ran a code formatter and it only
found one tab, and replaced it with spaces. I think the spaces/tabs are all
fixed (i'll double check tomorrow morning - its late here and my eyeballs are a
little weary).
1) removed the extra flume.conf good catch. Thats generated by the framework
actually.
2) Cleaned up the blank lines in the multiline runtime exception.
3) I actually would like to *keep the explicit tests files* for now. Maybe we
can add the dynamic stuff later on? For now, all tests are implemented by
explitly specifying them.
I agree its inelegant - but its uniform. Over time, we can add looser regexes
/etc for the tests which are in directories that don't require filters.
4) Regarding pi and the DFS comment changes : Out of scope? Sort of... but
Part of this JIRA is to clean up the tests to make tests easy to run - and that
means having accurate commants / reasonable defaults.
5) I've added back in the uncommented code: It is still used when we run tests
from jars, and I think we should support that functionality for while folks
migrate over to the new framework.
> Simplify and gradleize a subset of the bigtop smokes
> ----------------------------------------------------
>
> Key: BIGTOP-1222
> URL: https://issues.apache.org/jira/browse/BIGTOP-1222
> Project: Bigtop
> Issue Type: Improvement
> Components: Build, Tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: Konstantin Boudnik
> Fix For: backlog
>
> Attachments: BIGTOP-1222-2.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch
>
>
> (Rewritten the description for clarity)
> We need an easier way to run bigtop smoke tests, and gradle provides this:
> 1) Easy to script/modify
> 2) Human readable
> 3) equally oriented towards both groovy and plain old java
> The advantage of this method to running smokes :
> 1) No need to compile a jar : this is a costly step and not much value added,
> also creates indirection which can make debugging a broken test very hard.
> 2) Simple: A smoke test doesnt need to make low level API calls or be
> compiled against the right APIs - rather, it should test the end user
> interface ("hive -q ....", "pig -x ....", "hadoop jar ....", and so on).
> 3) Customizable: The smoke tests shouldnt require users to have to write XML
> and debug environmental variables / grep around for System properties etc.
> Rather, a high level controller should do all that checking for you.
> The initial idea was to write a python/bash implementation wrapper of
> scripts, but that was replaced by the idea of using gradle. The advantage of
> gradle is that we don't need to manually set the classpath and run groovy
> commands: Gradle wraps groovy scripts in their native java context quite
> nicely - but it doesnt add any other unnecessary overhead (xml, jar files, no
> need for complex xml tag wrappers for simple tasks - just plain groovy code).
> So, here the goal is just to create a nice, clean, extensible non-jar,
> non-API dependent gradle runner for the smoke tests which exersizes the
> hadoop cluster the same way a typical end-user would.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
