[
https://issues.apache.org/jira/browse/BIGTOP-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101261#comment-14101261
]
Konstantin Boudnik commented on BIGTOP-1222:
--------------------------------------------
Sorry, [~jayunit100] - I don't see it's happening: even with Gradle 2.0 ;(
Also, a couple more comments:
- thanks for moving {{bigtop-smoke-tests/}} under {{bigtop-tests}}. I think you
can safely call it just {{smoke-tests}} now - doesn't make much sense of having
{{bigtop-tests/bigtop...}} subdirectory.
- I see some of the tests are using {{println}} instead of proper logging?
Shall it be fixed?
- I see a number of tailing whitespaces in the patch. From git am output
{noformat}
Applying: BIGTOP-1222: Shiny new test framework for the hadoop ecosystem.
/home/cos/workspaces/bigtop/.git/rebase-apply/patch:57: trailing whitespace.
// Unpack resource
/home/cos/workspaces/bigtop/.git/rebase-apply/patch:107: trailing whitespace.
# This is the new smoke testing module for bigtop
/home/cos/workspaces/bigtop/.git/rebase-apply/patch:129: trailing whitespace.
gradle compileGroovy test -Dsmoke-tests=flume,hive --info
/home/cos/workspaces/bigtop/.git/rebase-apply/patch:1165: trailing whitespace.
/home/cos/workspaces/bigtop/.git/rebase-apply/patch:1169: trailing whitespace.
* See BIGTOP-1222 for example.
warning: squelched 22 whitespace errors
warning: 27 lines add whitespace errors.
{noformat}
> Simplify and gradleize a subset of the bigtop smokes
> ----------------------------------------------------
>
> Key: BIGTOP-1222
> URL: https://issues.apache.org/jira/browse/BIGTOP-1222
> Project: Bigtop
> Issue Type: Improvement
> Components: build, tests
> Affects Versions: 0.7.0
> Reporter: jay vyas
> Assignee: Konstantin Boudnik
> Fix For: backlog
>
> Attachments: BIGTOP-1222-2.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch, BIGTOP-1222.patch,
> BIGTOP-1222.patch, BIGTOP-1222.patch, newsmokes.png
>
>
> (Rewritten the description for clarity)
> We need an easier way to run bigtop smoke tests, and gradle provides this:
> 1) Easy to script/modify
> 2) Human readable
> 3) equally oriented towards both groovy and plain old java
> The advantage of this method to running smokes :
> 1) No need to compile a jar : this is a costly step and not much value added,
> also creates indirection which can make debugging a broken test very hard.
> 2) Simple: A smoke test doesnt need to make low level API calls or be
> compiled against the right APIs - rather, it should test the end user
> interface ("hive -q ....", "pig -x ....", "hadoop jar ....", and so on).
> 3) Customizable: The smoke tests shouldnt require users to have to write XML
> and debug environmental variables / grep around for System properties etc.
> Rather, a high level controller should do all that checking for you.
> The initial idea was to write a python/bash implementation wrapper of
> scripts, but that was replaced by the idea of using gradle. The advantage of
> gradle is that we don't need to manually set the classpath and run groovy
> commands: Gradle wraps groovy scripts in their native java context quite
> nicely - but it doesnt add any other unnecessary overhead (xml, jar files, no
> need for complex xml tag wrappers for simple tasks - just plain groovy code).
> So, here the goal is just to create a nice, clean, extensible non-jar,
> non-API dependent gradle runner for the smoke tests which exersizes the
> hadoop cluster the same way a typical end-user would.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
