[
https://issues.apache.org/jira/browse/BIGTOP-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120855#comment-14120855
]
stanley shi commented on BIGTOP-1424:
-------------------------------------
Hi [~cos], I just tested that compiling hive (with tests jar) takes less than
3min to finish on my VM (2 core, 8G mem); so this time should not be an issue.
{quote}As for getting a test jar from the external repo: is it really a concern
that warrants increasing the build time?{quote}
In this hive build scenario, we are building hive with the dependency of an
external hive (same version), I think this does not make sense.
Also I checked other components, they are all using "-DskipTests", I think at
least we should make it consistent.
> hive do-component-build should use skipTest instead of maven.test.skip
> ----------------------------------------------------------------------
>
> Key: BIGTOP-1424
> URL: https://issues.apache.org/jira/browse/BIGTOP-1424
> Project: Bigtop
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: stanley shi
>
> In the file bigtop-packages / src / common / hive / do-component-build, it is
> using
> -Dmaven.test.skip=true
> we should change to use
> -DskipTests
> The difference between these two:
> http://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-test.html
> -Dmaven.test.skip will not compile the test source code;
> -DskipTests will only skip the test;
> hive-service has dependency on hive-exec:
> {code}
> <dependency>
> <groupId>org.apache.hive</groupId>
> <artifactId>hive-exec</artifactId>
> <version>${project.version}</version>
> <scope>test</scope>
> <classifier>tests</classifier>
> </dependency>
> {code}
> without this fix, when build hive-service, it will get the hive-exec-test jar
> from apache maven repository instead of get what we just built.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
