[ 
https://issues.apache.org/jira/browse/BIGTOP-1388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161386#comment-14161386
 ] 

jay vyas edited comment on BIGTOP-1388 at 10/7/14 2:40 AM:
-----------------------------------------------------------

+1 

Hi [~dawson.choong] , the code looks good. 
- applied the patch using {{patch -p1 < ....}} fyi, so you might want to 
resubmit using git format-patch to make sure your author info is correct etc. 
otherwise let me kno what to use for the "--author" flag hen we commit it.

- Can we please accompany this feature with a comprehensive wiki page which 
details how to use cluster failure tests?  Ive added the stubs for you here 
https://cwiki.apache.org/confluence/display/BIGTOP/Running+integration+and+system+tests,
 and mentioned your name in the wiki page.   Id like to gate commiting this 
patch with an update to cos' wiki page on how to run the integration tests.

- Im currently running the smoke tests after applying your patch, will confirm 
that they still work in the morning.  In the meantime, can you update the wiki 
page above?  

Thanks! 






was (Author: jayunit100):
+1 

Hi [~dawson.choong] , the code looks good.  I applied the patch using {{patch 
-p1 < ....}} fyi, so you might want to resubmit using git format-patch to make 
sure your author info is correct etc. otherwise let me kno what to use for the 
"--author" flag hen we commit it.

Can we accompany this feature with a comprehensive wiki page which details how 
to use cluster failure tests?  Ive added the stubs for you here 
https://cwiki.apache.org/confluence/display/BIGTOP/Running+integration+and+system+tests,
 and mentioned your name in the wiki page.  

Im currently running the smoke tests after applying your patch, will confirm 
that they still work in the morning.  In the meantime, can you update the wiki 
page above?  
Thanks!






> Use cluster failure tests during other tests with command line parametrization
> ------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1388
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1388
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 0.7.0
>            Reporter: Dawson Choong
>            Assignee: Dawson Choong
>              Labels: patch
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1388.patch, BIGTOP-1388.patch
>
>
> User can run a series of cluster failures such as killing/restarting a 
> service and shutting down the network during a mapr or longevity test. The 
> goal is to test that the tests complete during the failures. The failures 
> should be able to be specified as a command line parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to