[
https://issues.apache.org/jira/browse/BIGTOP-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209492#comment-14209492
]
Konstantin Boudnik commented on BIGTOP-1493:
--------------------------------------------
A couple of comments:
- this look awkward: hadoop is normally expected to be found under
{{$HADOOP_HOME/bin}} rather than {{HADOOP_MAPREDUCE_HOME}}
{code}
"${hadoopMapredHome}/bin/hadoop
{code}
- I'd prefer an assert here (and in doFirst method) instead of using an
exception for control flow. Besides throwing and not catching an exception is a
bad idea
- if itest depends on asm (which I don't recall) shall we fix it in iTest
instead?
{code}
+ // looks like itest depends on this but doesn't get picked up properly
+ // assuming it gets this from hadoop which uses 3.2
+ testCompile 'asm:asm:3.2'
{code}
{code}
+ if (value == null) {
+ throw new NullPointerException()
{code}
Also, we are using enforcer plugin in Maven, so I am wondering if it's possible
to do something similar at the top level of Gradle build for smoke-tests? It
seems to be a feature that will be required all over the tests. Thoughts?
- I know that it is done everywhere in the smokes
{code}
+log4j.rootLogger=TRACE, A1
{code}
but shall we approach it similarly to how we've done it before in maven
executors poms? E.g. setting the log level to INFO by default via a property
available for all the tests and changeable in the runtime? See
{{bigtop-tests/test-execution/common/pom.xml}} for a reference. If you think it
is worthy - could open a JIRA so we can improve this later? In the meanwhile,
it isn't a blocker for this patch
Looks good otherwise. Thanks for working on that, David!
> Add smoke test for tachyon
> --------------------------
>
> Key: BIGTOP-1493
> URL: https://issues.apache.org/jira/browse/BIGTOP-1493
> Project: Bigtop
> Issue Type: Test
> Components: tests
> Affects Versions: 0.8.0
> Reporter: jay vyas
> Assignee: David Capwell
> Attachments: BIGTOP-1493.1.patch
>
>
> Tachyon as an in memory cache will be emerging as a common feature in hadoop
> and spark based clusters.
> Lets create a smoke test under the {{smoke-tests}} which uses the
> {{tachyon:///}} url.
> To get started with the smoke tests, you can
> 1) Run the vagrant recipe under bigtop-deploy/vm/vagrant-puppet . This will
> demonstrate the way you spin up a bigtop based hadoop cluster.
> 2) Now, you can do {{vagrant ssh}} into your cluster, and simply edit the
> smoke tests or install stuff. Re running the smoke-tests.sh file should test
> that your new tests work . At that point, just exit your VM, and commit your
> changes and submit the new patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
