[
https://issues.apache.org/jira/browse/BIGTOP-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216626#comment-14216626
]
Konstantin Boudnik edited comment on BIGTOP-1527 at 11/18/14 7:41 PM:
----------------------------------------------------------------------
Thanks Ivan. A few comments:
- would be good to add a HowTo not to {{README.md}} on how to use this new
feature. While I can guess the meaning of {{GIT_REPO}} and {{GIT_REF}} there's
no way a new developer can figure out on its own that such feature exists. So,
add a section a "For Developers: Building a component from Git repo" to the end
of the file.
- I did these changes to the datafu component
{code}
DATAFU_TARBALL_SRC=v$(DATAFU_BASE_VERSION).tar.gz
-DATAFU_SITE=https://github.com/linkedin/datafu/archive
-DATAFU_ARCHIVE=$(DATAFU_SITE)
[email protected]:linkedin/datafu.git
+DATAFU_GIT_REF=1.0.0
+DATAFU_ARCHIVE=$(DATAFU_GIT_REPO)
$(eval $(call PACKAGE,datafu,DATAFU))
{code}
and tried to build it. While cloning had happened I see that the resulting
tarball contains {{.git}} directory in it.
- also, the commit message should be in the form of "BIGTOP-1527. JIRA title"
- if cloning fails for whatever reason, the temp directory is left behind under
{{dl/}} directory. Which will fail the next run. Perhaps, it makes sense to
make sure the temp.dir is removed before cloning?
As for the missing {{depth}}: perhaps we shall offer a PR for the plugin? ;)
was (Author: cos):
Thanks Ivan. A few comments:
- would be good to add a HowTo not to {{README.md}} on how to use this new
feature. While I can guess the meaning of {{GIT_REPO}} and {{GIT_REF}} there's
no way a new developer can figure out on its own that such feature exists. So,
add a section a "For Developers: Building a component from Git repo" to the end
of the file.
- I did these changes to the datafu component
{code}
DATAFU_TARBALL_SRC=v$(DATAFU_BASE_VERSION).tar.gz
-DATAFU_SITE=https://github.com/linkedin/datafu/archive
-DATAFU_ARCHIVE=$(DATAFU_SITE)
[email protected]:linkedin/datafu.git
+DATAFU_GIT_REF=1.0.0
+DATAFU_ARCHIVE=$(DATAFU_GIT_REPO)
$(eval $(call PACKAGE,datafu,DATAFU))
{code}
and tried to build it. While cloning had happened I see that the resulting
tarball contains {{.git}} directory in it.
- also, the commit message should be in the form of "BIGTOP-1527. JIRA title"
As for the missing {{depth}}: perhaps we shall offer a PR for the plugin? ;)
> Allow to fetch package's source code from Git
> ---------------------------------------------
>
> Key: BIGTOP-1527
> URL: https://issues.apache.org/jira/browse/BIGTOP-1527
> Project: Bigtop
> Issue Type: Improvement
> Components: general
> Affects Versions: 0.8.0
> Reporter: Ivan Orlov
> Attachments: 0001-Allow-to-fetch-sources-from-Git.patch,
> 0001-Allow-to-fetch-sources-from-Git.patch
>
>
> For development purposes. It's useful to target Bigtop on Git-repository of
> your own package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
