[ 
https://issues.apache.org/jira/browse/BIGTOP-1553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236002#comment-14236002
 ] 

Konstantin Boudnik commented on BIGTOP-1553:
--------------------------------------------

Good stuff!
I see that you're doing the 2nd time
{code}
+  # See above explanation of the $all convention. 
+  $all = ($components[0]  == undef)
{code}
What's the reason?

Also, in a few places you do
{{+  if ($all == undef or "sqoop" in $components) {}}
while in the most others you're simply checking the value of {{$all}}. Looks 
like a context replacement issue. Please make it uniformed if possible.

> puppet installation fails when components value is a single item instead of a 
> list
> ----------------------------------------------------------------------------------
>
>                 Key: BIGTOP-1553
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1553
>             Project: Bigtop
>          Issue Type: Bug
>          Components: deployment
>    Affects Versions: 0.8.0
>            Reporter: Rob Leidle
>            Priority: Trivial
>             Fix For: 0.9.0
>
>         Attachments: BIGTOP-1553.patch, BIGTOP-1553.patch, BIGTOP-1553.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> If the value for components is a single value such as "hive" instead of a 
> list of values then the following error occurs:
> components is not an hash or array when accessing it with 0 at 
> /var/tmp/bigtop-0.8.0/bigtop-deploy/puppet/manifests/cluster.pp:123



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to