[
https://issues.apache.org/jira/browse/BIGTOP-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246184#comment-14246184
]
Konstantin Boudnik commented on BIGTOP-1560:
--------------------------------------------
Thanks for the update, [~dasha.boudnik]. two small comments:
- _grepIP_ isn't a method, but a constant
- one last thing was about replacing assert with assume (as I've mentioned in
[here|https://issues.apache.org/jira/browse/BIGTOP-1560?focusedCommentId=14234864&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14234864].
Assume will simply skip the test with an appropriate message on a single node
clusters instead of failing it. Do you think it'd make sense to do it this way?
Other than then I think the patch is ready to get committed. I will try it
today on a cluster spun with new hdfs keys to make sure it all works as
expected. If you can make the assume change above I should be able to commit it
given that the cluster test will pass.
Thanks
> Add a test case for performing block corruption recovery
> --------------------------------------------------------
>
> Key: BIGTOP-1560
> URL: https://issues.apache.org/jira/browse/BIGTOP-1560
> Project: Bigtop
> Issue Type: Test
> Components: tests
> Affects Versions: 0.8.0
> Reporter: Dasha Boudnik
> Assignee: Dasha Boudnik
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1560.patch, BIGTOP-1560.patch, BIGTOP-1560.patch
>
>
> Found this issue in internal testing. Roughly:
> create file in HDFS
> find block for the file
> corrupt a block
> trigger recovery by trying to read the file
> check recovery was successful
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
