[
https://issues.apache.org/jira/browse/BIGTOP-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14285094#comment-14285094
]
Konstantin Boudnik edited comment on BIGTOP-1334 at 1/21/15 3:20 AM:
---------------------------------------------------------------------
file TestDFSCLI is missing ASL boilerplate.
Also, to be very picky:
- {{ 0, conf.getInt("fs.trash.interval",0)); }} needs space after ","
- {code} System.getProperty("hcfs.root.username", "hdfs"),
username);
{code} should be written in one line
- {{@param cmd}} needs to have parameter description
- {{protected String expandCommand(final String cmd)}} final modifier for
String isn't harmful, but doesn't add anything as Strings are immutable. This
one is ok to keep as is, I think.
Thanks
was (Author: cos):
file TestDFSCLI is missing ASL boilerplate.
Also, to be very picky:
- {{ 0, conf.getInt("fs.trash.interval",0)); }} needs space after ","
- {code} System.getProperty("hcfs.root.username", "hdfs"),
username);
{code} should be written in one line
- {{ * @param cmd }} needs to have parameter description
- {{ protected String expandCommand(final String cmd) { }} final modifier for
String isn't harmful, but doesn't add anything as Strings are immutable. This
one is ok to keep as is, I think.
Thanks
> Add DFS tests to TestCLI
> ------------------------
>
> Key: BIGTOP-1334
> URL: https://issues.apache.org/jira/browse/BIGTOP-1334
> Project: Bigtop
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 0.7.0
> Reporter: Dasha Boudnik
> Assignee: Dasha Boudnik
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1334.patch, BIGTOP-1334.patch, BIGTOP-1334.patch,
> BIGTOP-1334.patch
>
>
> TestCLI currently does not support DFSadmin tests. Consequently, multiple
> tests, including snapshots, fail.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
