[
https://issues.apache.org/jira/browse/BIGTOP-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296208#comment-14296208
]
Konstantin Boudnik commented on BIGTOP-1325:
--------------------------------------------
Looks good. One comment though. When you do
{code}
+ <command>-fs NAMENODE -mkdir -p /user/USER_NAME/dir1</command>
+ <command>-fs NAMENODE -rmdir /user/USER_NAME/dir1</command>
+ <command>-fs NAMENODE -ls /user/USER_NAME/</command>
{code}
you are later checking that {{/user/USER_NAME/}} is empty (ie the ls on the
directory has no output). It might not be the case if cluster is active and
other clients are putting files under {{/user/USER_NAME/}}. I'd recommend to
do something like this
{code}
+ <command>-fs NAMENODE -mkdir -p /user/USER_NAME/dir1/dir2</command>
+ <command>-fs NAMENODE -rmdir /user/USER_NAME/dir1/dir2</command>
+ <command>-fs NAMENODE -ls /user/USER_NAME/dir1</command>
{code}
and then remove {{dir1}} as before. Makes sense?
> Update TestHDFSCLI to include tests from upstream
> -------------------------------------------------
>
> Key: BIGTOP-1325
> URL: https://issues.apache.org/jira/browse/BIGTOP-1325
> Project: Bigtop
> Issue Type: Improvement
> Components: tests
> Affects Versions: 0.7.0
> Reporter: Dasha Boudnik
> Assignee: Dasha Boudnik
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1325.patch, BIGTOP-1325.patch
>
>
> Add the following commands to TestCLI:
> appendToFile
> text
> rmdir
> rmdir with ignore-fail-on-non-empty
> df
> expunge
> getmerge
> The following tests have been added as TestDFSCLI in BIGTOP-1334:
> allowSnapshot
> disallowSnapshot
> createSnapshot
> renameSnapshot
> deleteSnapshot
> refreshUserToGroupsMappings
> refreshSuperUserGroupsConfiguration
> setQuota
> clrQuota
> setSpaceQuota
> setBalancerBandwidth
> finalizeUpgrade
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
