[
https://issues.apache.org/jira/browse/BIGTOP-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296347#comment-14296347
]
jay vyas edited comment on BIGTOP-1632 at 1/29/15 4:10 AM:
-----------------------------------------------------------
1) Hi [~biju74] , fyi, we sorta prefer for non trivial patches the {{git
format-patch}} method, which assigns you proper credit... not a huge deal but
maybe in the future you might want to use this when submitting patches...
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2) do we need an *if/else* here? seems like the "else" case actually is just
appending one more arg to the end, so it can just be an *if*, right? i.e.
{noformat}
if [ "x$JMXPORT" ! = "x" ] ; then
HBASE_MULTI_ARGS = "${HBASE_MULTI_ARGS} -Dhbase.@[email protected]=`expr
${FIRST_INFO_PORT} + ${OFFSET}` -Dcom.sun.management.jmxremote.port=`expr
${JMXPORT} + ${OFFSET}`"
fi
{noformat}
otherwise, makes sense to me... thanks !
was (Author: jayunit100):
1) Hi [~biju74] , fyi, we sorta prefer for non trivial patches the {{git
format-patch}} method, which assigns you proper credit... not a huge deal but
maybe in the future you might want to use this when submitting patches...
https://cwiki.apache.org/confluence/display/BIGTOP/How+to+Contribute
2) do we need an *if/else* here? seems like the "else" case actually is just
appending one more arg to the end, so it can just be an *if*, right? i.e.
{noformat}
if [ "x$JMXPORT" ! = "x" ] ; then
HBASE_MULTI_ARGS = "${HBASE_MULTI_ARGS} -D hbase.@[email protected]=`expr
${FIRST_INFO_PORT} + ${OFFSET}` \
+ -Dcom.sun.management.jmxremote.port=`expr
${JMXPORT} + ${OFFSET}`"
+ fi
{noformat}
otherwise, makes sense to me... thanks !
> Support JMX monitoring when multiple HBase RS is brought up in a node
> ---------------------------------------------------------------------
>
> Key: BIGTOP-1632
> URL: https://issues.apache.org/jira/browse/BIGTOP-1632
> Project: Bigtop
> Issue Type: Sub-task
> Components: hbase
> Reporter: Biju Nair
> Labels: hbase
> Fix For: 0.6.0
>
> Attachments: BIGTOP-1632-0.patch
>
>
> Update made to the HBase init.d script in BIGTOP-732 allows users to bring up
> more than 1 RS on a node. This task is to make changes to HBase init.d script
> which will allow users to perform monitoring of all the RS through JMX.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
