[
https://issues.apache.org/jira/browse/BIGTOP-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305424#comment-14305424
]
jay vyas edited comment on BIGTOP-1634 at 2/4/15 4:26 PM:
----------------------------------------------------------
Hi evans. I think the criteria for commit are simple.
- are the new features in this puppet file maintained by someone (for example I
see *kerberos*. Do we support that? journalling of HDFS. Do need/we have
maintainers for those?
- does the existing changes passing the *existing vagrant-docker or vm tests* ?
If so, and if the code passes your approval, then go ahead and commit ! :)
was (Author: jayunit100):
Hi evans. I think the criteria for commit are simple.
- are the new features in this puppet file maintained by someone (for example I
see *kerberos*. Do we support that? ) ?
- With journalling of HDFS, i didn't even know we supported that. maybe im
just behind. it looks like a good idea, but just want to make sure someone is
commited to maintaining.
- does the existing changes passing the *existing vagrant-docker or vm tests*
(which test puppet deploy of yarn, mapreduce, pig, ...) ?
If so, and if the code passes your approval, then go ahead and commit ! :)
Also , please also confirm that the heira stuff is sufficiently described in
the README.
> Puppet class parameter and hiera conversion
> -------------------------------------------
>
> Key: BIGTOP-1634
> URL: https://issues.apache.org/jira/browse/BIGTOP-1634
> Project: Bigtop
> Issue Type: Improvement
> Components: deployment
> Affects Versions: backlog
> Reporter: Michael Weiser
> Labels: patch
> Attachments:
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch,
> 0001-BIGTOP-1634-puppet-Replace-extlookup-with-hiera-use-.patch,
> 0002-BIGTOP-1634-Add-enhanced-configuration.patch
>
>
> As discussed on the DEV list:
> Update the puppet code to use self-contained, parametrised classes and proper
> scoping. Replace all extlookup calls bei either explicit or automatic hiera
> parameter lookups. Implement HA/non-HA alternative via hiera lookup
> hierarchy. Replace append_each from bigtop_util by suffix from stdlib. Do
> file imports via puppet:/// scheme. Remove bigtop_util because remaining
> function get_settings is not needed any more.
> Additionally: Add additional configuration options for zookeeper and yarn as
> well as a new class for journalnode configuration.
> I've separated it into two patches of ease of review:
> 0001: actual hiera/class conversion
> 0002: functional enhancements including journalnode configuration on top of
> that. Mainly meant as an example for ease of further expansion and
> containment of changes to single modules.
> This JIRA is meant for the stuff contained in 0001, the actual hiera
> conversion. I can resubmit 0002 as a separate JIRA if desired. Also it should
> be possible to backport 0002 to the current puppet code base without much
> fuss.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
