[
https://issues.apache.org/jira/browse/BIGTOP-1654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308814#comment-14308814
]
Evans Ye commented on BIGTOP-1654:
----------------------------------
hi [~vishnu] just one comment. Please based on BIGTOP-1634 to develop your
patch since we're going to get it in shortly, thanks!
> change some hadoop puppet variables from local to node scope
> ------------------------------------------------------------
>
> Key: BIGTOP-1654
> URL: https://issues.apache.org/jira/browse/BIGTOP-1654
> Project: Bigtop
> Issue Type: Bug
> Components: deployment, hadoop
> Affects Versions: 0.8.0
> Reporter: vishnu gajendran
> Labels: patch
> Fix For: 0.9.0
>
>
> the purpose of this change is to refactor certain puppet variables in
> cluster.pp and init.pp scripts. Precisely, I would like to change the
> configurable parameters like $ha and $auth from "local" to "node" scope. I
> believe, there is no need to pass in these variables to every module/class as
> these parameters doesn't change once set. With puppet 3 (static scoping) ,
> this change is mandatory as I currently see these variables ($ha, $auth)
> referenced in multiple places assuming that it is defined in some outer
> scope. This will not work with puppet 3.
> More details of static scoping:
> https://docs.puppetlabs.com/puppet/latest/reference/lang_scope.html#static-scope
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
