I see the following line in
https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/solr/install_solr.sh#L273
Presumably this was added so that "service solr-server stop" would work
correctly. I see a couple of problems with this:
1. This overwrites JAVA_OPTS even when we are not trying to stop the
service (e.g. when we do a (service solr-server start" )
2. If JAVA_OPTS is already set to something useful we will be overriding it
Roman, I see that you had made this change so was hoping you could comment
on this. Would it make sense to change it to something like
if [ "$1" = "stop" ] ; then
export JAVA_OPTS="$JAVA_OPTS $CATALINA_OPTS"
fi
Thanks,
RG
PS : The original code looks like this:
# FIXME: for some reason catalina doesn't use CATALINA_OPTS for stop action
# and thus doesn't know the admin port
export JAVA_OPTS="$CATALINA_OPTS"
