[
https://issues.apache.org/jira/browse/BIGTOP-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336599#comment-14336599
]
Evans Ye commented on BIGTOP-1693:
----------------------------------
I just thought that {{git am}} can preserve the author and commit messages:)
In the newest patch, vagrant installation in *deployment-tools.pp* has been
commented out. Is that intended?
I think originally the deployment_tools wrapper is used to setup a *controller*
node for running docker or vm provisioner. Things putting in it might be
vagrant, docker and some vagrant plugins installation recipes. Puppet modules
should be a different story. Maybe we can have another wrapper called
puppet_modules to install all the puppet modules. (besides stdlib, I've to add
apt module installation in it). How do you think?
> Puppet stdlib should be automatically installed by toolchain
> ------------------------------------------------------------
>
> Key: BIGTOP-1693
> URL: https://issues.apache.org/jira/browse/BIGTOP-1693
> Project: Bigtop
> Issue Type: Improvement
> Components: deployment
> Affects Versions: 0.8.0
> Reporter: Konstantin Boudnik
> Assignee: Konstantin Boudnik
> Fix For: 0.9.0
>
> Attachments: BIGTOP-1693.patch, BIGTOP-1693.patch, BIGTOP-1693.patch,
> BIGTOP-1693.patch
>
>
> Right now we have an explicit instruction for a user to install puppet stdlib
> before doing the deployment. This is a bad UX.
> I think the installation should be done in the
> {{bigtop_toolchain::deployment_tools}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)