[
https://issues.apache.org/jira/browse/BIGTOP-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345533#comment-14345533
]
Konstantin Boudnik commented on BIGTOP-1580:
--------------------------------------------
I think it all is good. One small nit (which might be legit, but I guess I need
more coffee still...)
There's an empty entry in BOM_map
{{BIGTOP_BUILD_STAMP: ''}}
followed by this change
{noformat}
-def final BIGTOP_BUILD_STAMP = System.getenv('BIGTOP_BUILD_STAMP') ?:
BOM_map['BIGTOP_BUILD_STAMP']
+def final BIGTOP_BUILD_STAMP = System.getenv('BIGTOP_BUILD_STAMP') ?
System.getenv('BIGTOP_BUILD_STAMP') : 1
{noformat}
Would it achieve the same effect if we just set the initial value of {[1}} to
that key above and keep the assignment statement?
> Improve Bigtop Toolchain: Versioning of Packages
> ------------------------------------------------
>
> Key: BIGTOP-1580
> URL: https://issues.apache.org/jira/browse/BIGTOP-1580
> Project: Bigtop
> Issue Type: Bug
> Components: build, debian, rpm
> Affects Versions: 0.3.0
> Reporter: Olaf Flebbe
> Assignee: Olaf Flebbe
> Fix For: 0.9.0
>
> Attachments:
> 0001-BIGTOP-1580-Change-Versioning-of-Packages.-BIGTOP_BU.patch,
> 0001-BIGTOP-1580-Change-Versioning-of-Packages.patch,
> 0001-BIGTOP-1580-Change-Versioning-of-Packages.patch
>
>
> Right now there is no build numbering (beyond -1 ) for different packaging
> attempts and bigtop releases.
> There is no workable way to increase build numbering in Bigtop. (At least
> this is the situation for ubuntu and debian, have not checked RPM).
> This leads to indentical package versions and buildnumbers for different
> bigtop builds when no package version upgrade has been made. This is not
> desirable , since it essentially disables package upgrades at all.
> There is a BIGTOP_BUILD_STAMP which could be used to introduce the needed
> semantics but sadly this BIGTOP_BUILD_STAMP is appended to the PKG_VERSION
> part of the numbering, not the RELEASE_VERSION part .
> I vote to move BIGTOP_BUILD_STAMP to the "right" place in the
> package-version: Appending to RELEASE_VERSION
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
