[ 
https://issues.apache.org/jira/browse/BIGTOP-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376634#comment-14376634
 ] 

jay vyas commented on BIGTOP-1758:
----------------------------------

+1 to commit if you think its a good idea .... even though the practical 
benefits of having the redundant check is actually valuable to people running 
these tests outside of maven.
ill let you decide , either way, the code looks fine.

> Remove redundant property checks from TestHadoopExamples
> --------------------------------------------------------
>
>                 Key: BIGTOP-1758
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-1758
>             Project: Bigtop
>          Issue Type: Bug
>          Components: tests
>    Affects Versions: 0.8.0
>            Reporter: Dasha Boudnik
>            Assignee: Dasha Boudnik
>             Fix For: 1.0.0
>
>         Attachments: BIGTOP-1758.patch
>
>
> HADOOP_MAPRED_HOME and HADOOP_CONF_DIR env variables are now defined and 
> enforced in appropriate pom files, so we should remove the checks for these 
> properties from TestHadoopExamples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to