+1 , also we can do this in CI? On Fri, Aug 7, 2015 at 10:24 PM, RJ Nowling <[email protected]> wrote:
> +1 > > On Fri, Aug 7, 2015 at 4:58 PM, Konstantin Boudnik <[email protected]> wrote: > > > Guys > > > > as a part of 1.0 I have stepped on a huge number of licensing violations > in > > the form of missing header files, etc. It is all fixed now both on > > branch-1.0 for upcoming 1.0 release and on the master. Because RAT check > is > > clean now, let's keep it this way. Hence I have added the following to > out > > patch preparation Wiki page: > > > > Run mvn apache-rat:check to make sure that newly added files do not have > > any > > licensing issues. When in doubt refer to > https://www.apache.org/licenses/ > > > > I think patch reviewers need to check the correctness of the license > > headers > > as a part of their review routine.. > > > > Regards, > > Cos > > > > > -- jay vyas
