Github user youngwookim commented on the pull request:

    https://github.com/apache/bigtop/pull/24#issuecomment-129745248
  
    Got it, It's not a bug, Github's 'patch' is not same as 'diff'. I did not 
know that! :-( I think fixing the commit history is not easy at this point so I 
would encourage you to make new PR or patch from the current diff -- 
https://github.com/apache/bigtop/pull/24.diff 
    
    First, please make a fresh branch and then apply your changes into the 
branch with a same commit message. like below:
    1. Download current diff from github:
    ```
    cd /tmp/
    wget https://github.com/apache/bigtop/pull/24.diff
    ```
    2. Apply the diff (again):
    ```
    git pull asf master
    git checkout -b BIGTOP-1126
    git apply /tmp/24.diff
    git add -A
    git commit -m 'BIGTOP-1126. ...'
    git push origin BIGTOP-1126
    ```
    And then, please re-send a PR. Maybe... there are better ways but don't 
know exactly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to