+1. I think you can just commit and enable it. If it failed we can fix it
latter. That's not a big deal.

2015-12-02 8:54 GMT+08:00 Konstantin Boudnik <[email protected]>:

> I'd say go for it, because all reasonable testing efforts were made while
> you
> developed the patch. If something breaks in the CI - we'll simply fix it.
>
> Cos
>
> On Tue, Dec 01, 2015 at 11:44PM, Olaf Flebbe wrote:
> > Hi,
> >
> > I worked the last days on adding a artifact repository proxy support at
> our build environment:
> >
> >
> https://issues.apache.org/jira/browse/BIGTOP-2081?focusedCommentId=15034750&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15034750
> >
> > It works for me ;-)
> >
> > But the ultimate challenge would be our CI. Should I add a new CI job or
> is it ok to commit and enable ?
> >
> > Olaf
>
>
>

Reply via email to