Github user ktsakalozos commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/123#discussion_r67843645
--- Diff: bigtop-packages/src/charm/mahout/layer-mahout/actions/smoke-test
---
@@ -0,0 +1,20 @@
+#!/bin/bash
+#
+set -ex
+
+if hdfs dfs -stat /tmp/input/ &> /dev/null; then
+ hdfs dfs -rm -r -skipTrash /tmp/input/ || true
+fi
+
+hdfs dfs -mkdir /tmp/input/
+hdfs dfs -put resources/links-converted.txt /tmp/input/
+hdfs dfs -put resources/users.txt /tmp/input/
+
+if hdfs dfs -stat temp &> /dev/null; then
+ hdfs dfs -rm -r -skipTrash temp || true
+fi
+if hdfs dfs -stat output &> /dev/null; then
+ hdfs dfs -rm -r -skipTrash output || true
+fi
+
+hadoop jar /usr/lib/mahout/mahout-mr-0.11.1-job.jar
org.apache.mahout.cf.taste.hadoop.item.RecommenderJob
-Dmapred.input.dir=/tmp/input/links-converted.txt -Dmapred.output.dir=output
--usersFile /tmp/input/users.txt --booleanData -s SIMILARITY_LOGLIKELIHOOD
--- End diff --
As far as I can tell Bigtop does not yet package Mahout 0.12.2.
So, I updated the action script and used a wildcard instead of a fixed
Mahout version. This was tested against a manual deployment of 0.12.2 Mahout.
Unless there are significant changes in either the packaging of Mahout or the
internals of the jar, the test should be valid for both the current and future
Mahout versions.
Thank you for spotting this and helping improve the quality of the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
