Github user chinmaykolhatkar commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/188#discussion_r108093171
  
    --- Diff: bigtop-packages/src/common/apex/do-component-build ---
    @@ -26,10 +26,10 @@ command -v mvn > /dev/null 2>&1 || {
     }
     
     # Build apex
    -mvn clean package -DskipTests "$@"
    +mvn clean package -DskipTests -Dhadoop.version=$HADOOP_VERSION "$@"
     
     # Find all the dependencies of apex
    -mvn dependency:copy-dependencies -DoutputDirectory=`pwd`/all-deps 
-DincludeScope=runtime -DexcludeScope=test
    +mvn dependency:copy-dependencies -DoutputDirectory=`pwd`/all-deps 
-DincludeScope=runtime -DexcludeScope=test -Dhadoop.version=$HADOOP_VERSION
    --- End diff --
    
    Agreed. I request this to be taken as an improvement for building apex 
component as a seperate Jira. Currently the apex component is broken and I 
believe that should be fixed. Let me know if this is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to