Github user kwmonroe commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/197#discussion_r112989226
--- Diff:
bigtop-packages/src/charm/hadoop/layer-hadoop-resourcemanager/actions/smoke-test
---
@@ -43,6 +43,6 @@ smoke_env = {
bigtop = Bigtop()
result = bigtop.run_smoke_tests(smoke_components, smoke_env)
if result == 'success':
- hookenv.action_set({'outcome': result})
+ hookenv.action_set({'outcome': 'success'})
else:
- fail('{} smoke tests failed'.format(smoke_components), result)
+ fail('{} smoke tests failed with: {}'.format(smoke_components, result))
--- End diff --
@johnsca, I merged the output with the message to be consistent with other
bigtop charms. When an action fails, users expect to see the reason in the
`message` key. Without this change, they would see the abbreviated failure
message and need to know to look elsewhere for an `output` key.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
