Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/259#discussion_r131934559
  
    --- Diff: docker/sandbox/build.sh ---
    @@ -65,7 +65,11 @@ generate_tag() {
     
     detect_repo() {
         OS_SEP_BY_SLASH=${OS/-//}
    -    
REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/x86_64"}
    +    if [ $HOSTTYPE = "aarch64" ] ; then
    +       
REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/aarch64"}
    +    else
    +       
REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/x86_64"}
    +    fi
    --- End diff --
    
    It seems we can put HOSTTYPE in the REPO variable directly since I got 
exactly "x86_64" on x86_64 systems.
    
    
REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/$HOSTTYPE"}
    
    How do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to