Github user c0s commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/268#discussion_r130447063
  
    --- Diff: bigtop-tests/smoke-tests/spark/TestSpark.groovy ---
    @@ -73,7 +75,7 @@ class TestSpark {
         // 'yarn-client' mode
         String masterMode = 'yarn-client'
         if (System.env.SPARK_MASTER_IP != null && System.env.SPARK_MASTER_PORT 
!= null)
    --- End diff --
    
    As you introduce new constants above for these environment variables, you 
can as well use them for this check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to