Github user c0s commented on a diff in the pull request:
https://github.com/apache/bigtop/pull/282#discussion_r137376595
--- Diff: packages.gradle ---
@@ -185,7 +185,7 @@ def genTasks = { target ->
def final GIT_USER_NAME = config.bigtop.components[target].git.user ?:
config.bigtop.git.user
def final GIT_ACCESS_TOKEN =
config.bigtop.components[target].git.token ?: config.bigtop.git.token
- if (!DOWNLOAD_URL)
+ if (!DOWNLOAD_URL && !(GIT_REPO && GIT_REF))
--- End diff --
Good catch!
Took me a while to get the full picture, and I even had to write a small
test to see the truth matrix
```
#!/usr/bin/env groovy
def final BOOLS = [false, true]
for (DOWNLOAD_URL in BOOLS)
for (GIT_REPO in BOOLS)
for (GIT_REF in BOOLS) {
println("$DOWNLOAD_URL $GIT_REPO $GIT_REF")
println ("\t\t\t ${(!DOWNLOAD_URL && !(GIT_REPO &&
GIT_REF)).toString().toUpperCase()}")
}
```
but everything worked out just fine.
+1 will commit it shortly
---
